ptupitsyn commented on code in PR #1868: URL: https://github.com/apache/ignite-3/pull/1868#discussion_r1153119641
########## modules/platforms/dotnet/Apache.Ignite/Internal/Metrics.cs: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Ignite.Internal; + +using System.Diagnostics.CodeAnalysis; +using System.Diagnostics.Metrics; + +/// <summary> +/// Ignite.NET client metrics. +/// </summary> +[SuppressMessage( + "StyleCop.CSharp.OrderingRules", + "SA1202:Elements should be ordered by access", + Justification = "Meter should be private and comes before metrics.")] +internal static class Metrics +{ + private static readonly Meter Meter = new(name: "Apache.Ignite", version: "3.0.0"); + + /// <summary> + /// Currently active connections. + /// </summary> + public static readonly Counter<int> ConnectionsActive = Meter.CreateCounter<int>("connections-active"); + + /// <summary> + /// Total number of connections established. + /// </summary> + public static readonly Counter<int> ConnectionsEstablished = Meter.CreateCounter<int>("connections-established"); + + /// <summary> + /// Total number of connections lost. + /// </summary> + public static readonly Counter<int> ConnectionsLost = Meter.CreateCounter<int>("connections-lost"); + + /// <summary> + /// Total number of connections lost due to timeout. + /// </summary> + public static readonly Counter<int> ConnectionsLostTimeout = Meter.CreateCounter<int>("connections-lost-timeout"); + + /// <summary> + /// Handshakes failed. + /// </summary> + public static readonly Counter<int> HandshakesFailed = Meter.CreateCounter<int>("handshakes-failed"); + + /// <summary> + /// Handshakes failed due to a timeout. + /// </summary> + public static readonly Counter<int> HandshakesFailedTimeout = Meter.CreateCounter<int>("handshakes-failed-timeout"); + + /// <summary> + /// Currently active requests (request sent, waiting for response). + /// </summary> + public static readonly Counter<int> RequestsActive = Meter.CreateCounter<int>("requests-active"); + + /// <summary> + /// Requests sent. + /// </summary> + public static readonly Counter<int> RequestsSent = Meter.CreateCounter<int>("requests-sent"); + + /// <summary> + /// Requests completed (response received). + /// </summary> + public static readonly Counter<int> RequestsCompleted = Meter.CreateCounter<int>("requests-completed"); + + /// <summary> + /// Total number of request retries. + /// </summary> + public static readonly Counter<int> RequestsRetried = Meter.CreateCounter<int>("requests-retried"); + + /// <summary> + /// Requests failed. + /// </summary> + public static readonly Counter<int> RequestsFailed = Meter.CreateCounter<int>("requests-failed"); Review Comment: Changed all metrics to `long`, I guess there is no advantage to use `int` at all, we are not trying to save bytes here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
