alievmirza commented on code in PR #1819:
URL: https://github.com/apache/ignite-3/pull/1819#discussion_r1155580269


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java:
##########
@@ -179,6 +179,10 @@ public CompletableFuture<Void> completeJoinCluster() {
                 });
     }
 
+    public CompletableFuture<Void> completeJoinCluster() {

Review Comment:
   removed



##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/topology/LogicalTopologyImpl.java:
##########
@@ -67,25 +68,25 @@ private LogicalTopologySnapshot readLogicalTopology() {
     }
 
     @Override
-    public void onNodeValidated(ClusterNode node) {
+    public void onNodeValidated(LogicalNode node) {
         notifyListeners(listener -> listener.onNodeValidated(node), 
"onNodeValidated");
     }
 
     @Override
-    public void onNodeInvalidated(ClusterNode node) {
+    public void onNodeInvalidated(LogicalNode node) {
         notifyListeners(listener -> listener.onNodeInvalidated(node), 
"onNodeInvalidated");
     }
 
     @Override
-    public void putNode(ClusterNode nodeToPut) {
+    public void putNode(LogicalNode nodeToPut) {
         LogicalTopologySnapshot snapshot = readLogicalTopology();
 
-        Map<String, ClusterNode> mapByName = snapshot.nodes().stream()
+        Map<String, LogicalNode> mapByName = snapshot.nodes().stream()
                 .collect(toMap(ClusterNode::name, identity()));

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to