ibessonov commented on code in PR #1883:
URL: https://github.com/apache/ignite-3/pull/1883#discussion_r1155861240
##########
modules/configuration-api/src/main/java/org/apache/ignite/configuration/notifications/ConfigurationNotificationEvent.java:
##########
@@ -35,11 +35,31 @@
*/
@Nullable VIEWT oldValue();
+ /**
+ * Returns old value of the parent (any from the root) or current
configuration.
+ *
+ * <p>For example, if we changed the child configuration, then we can get
both the parent and the current child configuration.
+ *
+ * @param viewClass Configuration interface, for example {@code
RootView.class}.
+ * @param <T> Configuration type.
+ */
+ @Nullable <T> T oldValue(Class<T> viewClass);
Review Comment:
We should leave the method without parameters, because unlike
`oldValue(FooView.class)`, `oldValue()` may return `String` / `Integer` / etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
