denis-chudov commented on code in PR #1871:
URL: https://github.com/apache/ignite-3/pull/1871#discussion_r1156413782
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -179,24 +240,32 @@ public void run() {
Lease lease = leaseTracker.getLease(grpId);
+ if (!lease.isAccepted()) {
+ LeaseAgreement agreement =
leaseConciliator.conciliated(grpId);
+
+ if (agreement.isAccepted()) {
+ acceptLeasInMetaStorage(grpId, lease);
+ }
+ }
Review Comment:
There should be a check that the agreement contains the same lease. But in
general, I would say that it should not be done here, but in the handler of
LeaseGrantMessageResponse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
