sanpwc commented on code in PR #1729:
URL: https://github.com/apache/ignite-3/pull/1729#discussion_r1157209171
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -501,6 +543,222 @@ public int getZoneId(String name) {
}
}
+ /**
+ * The method for obtaining data nodes of the specified zone.
+ * The flow for the future completion:
+ * Waiting for DistributionZoneManager observe passed topology version or
greater version in topologyWatchListener.
+ * If the {@link
DistributionZoneConfigurationSchema#dataNodesAutoAdjustScaleUp} equals to 0
than wait for writing data nodes triggered
+ * by started nodes and corresponding to the passed topology version or
greater topology version
+ * to the data nodes into the meta storage.
+ * If the {@link
DistributionZoneConfigurationSchema#dataNodesAutoAdjustScaleDown} equals to 0
than wait for writing data nodes
+ * triggered by stopped nodes and corresponding to the passed topology
version or greater topology version
+ * to the data nodes into the meta storage.
+ * After waiting it returns the future with data nodes of the specified
zone.
+ *
+ * @param zoneId Zone id.
+ * @param topVer Topology version.
+ * @return The data nodes future.
+ */
+ public CompletableFuture<Set<String>> topologyVersionedDataNodes(int
zoneId, long topVer) {
+ CompletableFuture<Void> topVerFut = awaitTopologyVersion(topVer);
+
+ CompletableFuture<IgniteBiTuple<Boolean, Boolean>> timerValuesFut =
getImmediateTimers(zoneId, topVerFut);
+
+ CompletableFuture<Void> topVerScaleUpFut = scaleUpAwaiting(zoneId,
timerValuesFut);
+
+ CompletableFuture<Void> topVerScaleDownFut = scaleDownAwaiting(zoneId,
timerValuesFut);
+
+ return getDataNodesFuture(zoneId, topVerScaleUpFut,
topVerScaleDownFut);
+ }
+
+ /**
+ * Waits for DistributionZoneManager observe passed topology version or
greater version in topologyWatchListener.
+ *
+ * @param topVer Topology version.
+ * @return Future for chaining.
+ */
+ private CompletableFuture<Void> awaitTopologyVersion(long topVer) {
+ synchronized (dataNodesMutex) {
Review Comment:
Do you really need `synchronized (dataNodesMutex)` or it's possible to use
non-blocking approach? In other words, why do you need `synchronized
(dataNodesMutex)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
