rpuch commented on code in PR #1887:
URL: https://github.com/apache/ignite-3/pull/1887#discussion_r1160762763
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -833,7 +833,16 @@ protected Entry decodeEntry(byte[] key, byte[] value) {
return EntryImpl.empty(key);
}
- return doGetValue(key, targetRevision);
+ // This is not a correct approach for using locks in terms
of compaction correctness (we should block compaction for the
+ // whole iteration duration). However, compaction is not
fully implemented yet, so this lock is taken for consistency
+ // sake. This part must be rewritten in the future.
Review Comment:
Ok, it was optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
