ptupitsyn commented on code in PR #1918:
URL: https://github.com/apache/ignite-3/pull/1918#discussion_r1161423308
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -608,4 +637,46 @@ public void exceptionCaught(ChannelHandlerContext ctx,
Throwable cause) {
ctx.close();
}
+
+ @Override
+ public CompletableFuture<?>
onUpdate(ConfigurationNotificationEvent<AuthenticationView> ctx) {
+ return CompletableFuture.runAsync(() -> {
Review Comment:
Is there a reason to use `runAsync`? Looks like we can run the code
synchronously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
