ptupitsyn commented on code in PR #1927:
URL: https://github.com/apache/ignite-3/pull/1927#discussion_r1162588237
##########
modules/client/src/test/java/org/apache/ignite/client/ClientTupleTest.java:
##########
@@ -353,13 +270,36 @@ public void testTupleEqualityCompatibility() {
assertEquals(clientTuple.hashCode(), tuple.hashCode());
}
- private static ClientTuple getBuilder() {
- return new ClientTuple(SCHEMA);
+ private static Tuple getTuple() {
Review Comment:
Fixed.
##########
modules/client/src/test/java/org/apache/ignite/client/ClientTupleTest.java:
##########
@@ -353,13 +270,36 @@ public void testTupleEqualityCompatibility() {
assertEquals(clientTuple.hashCode(), tuple.hashCode());
}
- private static ClientTuple getBuilder() {
- return new ClientTuple(SCHEMA);
+ private static Tuple getTuple() {
+ var binTupleBuf = new BinaryTupleBuilder(SCHEMA.columns().length,
false)
+ .appendLong(3L)
+ .appendString("Shirt")
+ .build();
+
+ var binTuple = new BinaryTupleReader(SCHEMA.columns().length,
binTupleBuf);
+
+ return new ClientTuple(SCHEMA, binTuple, 0, SCHEMA.columns().length);
}
- private static Tuple getTuple() {
- return new ClientTuple(SCHEMA)
- .set("id", 3L)
- .set("name", "Shirt");
+ private static ClientTuple getFullSchemaTuple() {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
