alievmirza commented on code in PR #1729:
URL: https://github.com/apache/ignite-3/pull/1729#discussion_r1163605737
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -631,7 +820,15 @@ public void stop() throws Exception {
logicalTopologyService.removeEventListener(topologyEventListener);
- metaStorageManager.unregisterWatch(watchListener);
+ metaStorageManager.unregisterWatch(topologyWatchListener);
+ metaStorageManager.unregisterWatch(dataNodesWatchListener);
+
+ topVerTracker.update(Long.MAX_VALUE);
Review Comment:
Let's move it a constant value and add a comment, why Long.MAX_VALUE)
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -578,6 +759,10 @@ private ConfigurationListener<Integer> onUpdateScaleUp() {
zoneState.stopScaleUp();
}
+ if (newScaleUp > 0) {
Review Comment:
Please add explaining comment here, why we need to do
`zoneState.scaleUpRevisionTracker().update(lastScaleUpRevision)` in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
