J-Bakuli commented on code in PR #10328:
URL: https://github.com/apache/ignite/pull/10328#discussion_r1164054591
##########
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/cache/IdleVerify.java:
##########
@@ -341,6 +343,15 @@ private void cacheIdleVerifyV2(
if (F.isEmpty(res.exceptions()))
return;
+ Optional<Exception> inactiveE = res.exceptions().values()
+ .stream()
+ .filter(e -> X.hasCause(e,
VerifyBackupPartitionsTaskV2.IDLE_VERIFY_ON_INACTIVE_CLUSTER_ERROR_MESSAGE,
+ IgniteException.class))
+ .findFirst();
+
+ if (inactiveE.isPresent())
+ throw new IllegalStateException(inactiveE.get().getMessage());
Review Comment:
In "idle_verify..txt" file mostly per-node exceptions are written.
If the cluster is inactive there is no sense in a batch of equal per-node
exceptions there.
If to write this exception in control.sh log instead, "illegal state" will
be easier to find as it will be closer to the final users.
Users check log more often than "idle_verify..txt" file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
