vldpyatkov commented on code in PR #1872:
URL: https://github.com/apache/ignite-3/pull/1872#discussion_r1169834585
##########
modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java:
##########
@@ -18,29 +18,53 @@
package org.apache.ignite.internal.distributionzones;
import java.util.concurrent.CompletableFuture;
+import java.util.function.Consumer;
import
org.apache.ignite.internal.distributionzones.DistributionZoneConfigurationParameters.Builder;
+import
org.apache.ignite.internal.schema.configuration.storage.DataStorageChange;
/**
* Utils to manage distribution zones inside tests.
*/
public class DistributionZonesTestUtil {
+
/**
* Creates distribution zone.
*
* @param zoneManager Zone manager.
* @param zoneName Zone name.
* @param partitions Zone number of partitions.
* @param replicas Zone number of replicas.
+ * @param dataStorageChangeConsumer Consumer of {@link DataStorageChange},
which sets the right data storage options.
* @return A future, which will be completed, when create operation
finished.
*/
public static CompletableFuture<Integer> createZone(
- DistributionZoneManager zoneManager, String zoneName, int
partitions, int replicas) {
+ DistributionZoneManager zoneManager, String zoneName,
+ int partitions, int replicas, Consumer<DataStorageChange>
dataStorageChangeConsumer) {
Review Comment:
Each parameter should start from a new line, in case of not enough
characters for entire function definition in one line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
