ygerzhedovich commented on code in PR #1849:
URL: https://github.com/apache/ignite-3/pull/1849#discussion_r1170963796
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java:
##########
@@ -317,6 +319,82 @@ private static Stream<Arguments>
commonTypeForBinaryComparison() {
return arguments.stream();
}
+ @ParameterizedTest
+ @MethodSource("widerTypeForCustomTypes")
+ public void testWiderTypeForCustomTypes(RelDataType type1, RelDataType
type2, RelDataType expectedType) {
+ runTest("SELECT 1", (planner, ignore) -> {
Review Comment:
for the case, when query doesn't matter may create a new method ?
``private void runTest(BiConsumer<IgnitePlanner, SqlNode> testCase) {
runTest("SELECT 1", testCase, null);
}``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
