PakhomovAlexander commented on code in PR #1929:
URL: https://github.com/apache/ignite-3/pull/1929#discussion_r1172368128
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationRegistry.java:
##########
@@ -96,8 +83,11 @@ public class ConfigurationRegistry implements
IgniteComponent, ConfigurationStor
/** Configuration change handler. */
private final ConfigurationChanger changer;
- /** Configuration generator. */
- private final ConfigurationAsmGenerator cgen = new
ConfigurationAsmGenerator();
+ /** Runtime implementations generator for node classes. */
+ private final ConfigurationTreeGenerator generator;
+
+ /** Flag that indicates if the {@link ConfigurationTreeGenerator} instance
is owned by this object or not. */
+ private boolean ownConfigTreeGenerator = false;
Review Comment:
"I believe that generator can always be a constructor parameter" -- not
really. `ConfigurationRegistry` instance that uses
`LocalFileConfigurationStorage` should NOT create `ConfigurationTreeGenerator
` because it is passed ouside.
But if `ConfigurationRegistry` instance uses
`DistributedConfiguraitonStorage` (that does not know about
`ConfigurationTreeGenerator`) that it should create
`ConfigurationTreeGenerator` in order to pass it into `Changer`. In this case
there is no need to pass `ConfigurationTreeGenerator` from the "parent".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
