ptupitsyn commented on code in PR #1956:
URL: https://github.com/apache/ignite-3/pull/1956#discussion_r1172368057
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/core/rest/ApiClientSettings.java:
##########
@@ -72,8 +72,8 @@ public String trustStorePassword() {
return trustStorePassword;
}
- public String basicAuthLogin() {
- return basicAuthLogin;
+ public String basicAuthUsername() {
Review Comment:
`auth` is ambiguous: authentication or authorization? Let's rename
`basicAuthUsername` and `basicAuthPassword` everywhere to
`basicAuthenticationUsername` and `basicAuthenticationPassword`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
