AMashenkov commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1173798341
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcConnection.java:
##########
@@ -367,6 +374,20 @@ public void rollback(Savepoint savepoint) throws
SQLException {
throw new SQLFeatureNotSupportedException("Savepoints are not
supported.");
}
+ /**
+ * Finish transaction.
+ *
+ * @param commit {@code True} to commit, {@code false} to rollback.
+ * @throws SQLException If failed.
+ */
+ private void finishTx(boolean commit) throws SQLException {
+ JdbcFinishTxResult res = handler().finishTxAsync(connectionId,
commit).join();
Review Comment:
I mean the thread waiting on future.get() can be interrupted and a client
application can continue work.
The future.join() ignores interrupts and the thread will hang forever. The
only way is to kill JVM.
We have faced similar issues with future.join() on TC that lead to test
suite hanging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
