rpuch commented on code in PR #1973:
URL: https://github.com/apache/ignite-3/pull/1973#discussion_r1176148192
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -352,7 +353,8 @@ public class IgniteImpl implements Ignite {
ReplicaService replicaSvc = new
ReplicaService(clusterSvc.messagingService(), clock);
- txManager = new TxManagerImpl(replicaSvc, lockMgr, clock);
+ // TODO: IGNITE-19344 - use nodeId that is validated on join (and
probably generated differently).
+ txManager = new TxManagerImpl(replicaSvc, lockMgr, clock, new
TransactionIdGenerator(() -> clusterSvc.nodeName().hashCode()));
Review Comment:
`nodeId` mentioned in the TODO does not yet exist, it should be a 32-bit
number, and the mentioned ticket is about adding this `nodeId` (maybe the name
is not perfect).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
