SammyVimes commented on code in PR #1983:
URL: https://github.com/apache/ignite-3/pull/1983#discussion_r1177426605
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/snapshot/SnapshotExecutorImpl.java:
##########
@@ -250,7 +250,13 @@ public boolean init(final SnapshotExecutorOptions opts) {
final FirstSnapshotLoadDone done = new FirstSnapshotLoadDone(reader);
Requires.requireTrue(this.fsmCaller.onSnapshotLoad(done));
try {
- done.waitForRun();
+ // TODO: IGNITE-19363 We want to avoid deadlock for now, but this
is an ad-hoc decision.
+ // We don't wait for the partition's snapshot load closure to
finish here.
+ if (!node.getNodeId().getGroupId().contains("part")) {
+ done.waitForRun();
+ } else {
+ done.status = new Status();
Review Comment:
This is a temporal solution, so we don't really care about failing loading
the snapshot. The race doesn't matter, we won't be checking the result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
