zstan commented on code in PR #1982:
URL: https://github.com/apache/ignite-3/pull/1982#discussion_r1180048625
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/Commons.java:
##########
@@ -142,8 +142,9 @@ public final class Commons {
.withExpand(false)
.withHintStrategyTable(
HintStrategyTable.builder()
- .hintStrategy("DISABLE_RULE", (hint, rel)
-> true)
- .hintStrategy("EXPAND_DISTINCT_AGG",
(hint, rel) -> rel instanceof Aggregate)
+
.hintStrategy(Hints.ENFORCE_JOIN_ORDER.name(), (hint, rel) -> true)
Review Comment:
why did we want to hold predicate rule configuration as lambdas ? i.e. : rel
instanceof Aggregate ?
check for example : org.apache.calcite.rel.hint.HintPredicates seems it\`s
more clear and seems it\`s @lowka is talking about.
Additionally why new rule is propageted for all rels ? Not for : **rel
instanceof Join** ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
