rpuch commented on code in PR #1978:
URL: https://github.com/apache/ignite-3/pull/1978#discussion_r1180487356
##########
modules/network/src/main/java/org/apache/ignite/internal/network/netty/HandshakeHandler.java:
##########
@@ -67,7 +67,13 @@ public void handlerAdded(ChannelHandlerContext ctx) {
/** {@inheritDoc} */
@Override
public void channelActive(ChannelHandlerContext ctx) {
- manager.onConnectionOpen();
+ try {
+ manager.onConnectionOpen();
+ } catch (RuntimeException | AssertionError e) {
+ LOG.error("Error in onConnectionOpen()", e);
Review Comment:
No, I added this intentionally. Without this, an exception gets silently
swallowed (at least, I was not able to see exceptions that were happening until
I added this logging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
