ibessonov commented on code in PR #1693:
URL: https://github.com/apache/ignite-3/pull/1693#discussion_r1182252240
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java:
##########
@@ -743,7 +744,7 @@ private void sendEmptyEntries(final boolean isHeartbeat) {
private void sendEmptyEntries(final boolean isHeartbeat,
final RpcResponseClosure<AppendEntriesResponse> heartBeatClosure) {
final AppendEntriesRequestBuilder rb =
raftOptions.getRaftMessagesFactory().appendEntriesRequest();
- rb.timestamp(options.getNode().clockNow());
+ rb.timestampLong(nullableLongTime(options.getNode().clockNow()));
Review Comment:
I think that this simply is a bad name for the method, because it implies
nullable parameter, not nullable result. I'll rename it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
