timoninmaxim commented on code in PR #10678:
URL: https://github.com/apache/ignite/pull/10678#discussion_r1182532744
##########
modules/core/src/main/java/org/apache/ignite/internal/management/ChangeTagCommandArg.java:
##########
@@ -15,45 +15,48 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.visor.misc;
+package org.apache.ignite.internal.management;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import org.apache.ignite.internal.dto.IgniteDataTransferObject;
-
-/**
- *
- */
-public class VisorClusterChangeTagTaskArg extends IgniteDataTransferObject {
+import org.apache.ignite.internal.management.api.Argument;
+import org.apache.ignite.internal.management.api.CliConfirmParameter;
+import org.apache.ignite.internal.management.api.Positional;
+import org.apache.ignite.internal.util.typedef.internal.U;
+
+/** */
+@CliConfirmParameter
+public class ChangeTagCommandArg extends IgniteDataTransferObject {
/** */
- private static final long serialVersionUID = 0L;
+ private static final long serialVersionUID = 0;
Review Comment:
Why not "0L"? As I can see almost all places in our code uses "0L"
##########
modules/core/src/main/java/org/apache/ignite/internal/management/ChangeTagCommandArg.java:
##########
@@ -15,45 +15,48 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.visor.misc;
+package org.apache.ignite.internal.management;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import org.apache.ignite.internal.dto.IgniteDataTransferObject;
-
-/**
- *
- */
-public class VisorClusterChangeTagTaskArg extends IgniteDataTransferObject {
+import org.apache.ignite.internal.management.api.Argument;
+import org.apache.ignite.internal.management.api.CliConfirmParameter;
+import org.apache.ignite.internal.management.api.Positional;
+import org.apache.ignite.internal.util.typedef.internal.U;
+
+/** */
+@CliConfirmParameter
+public class ChangeTagCommandArg extends IgniteDataTransferObject {
/** */
- private static final long serialVersionUID = 0L;
+ private static final long serialVersionUID = 0;
/** */
- private String newTag;
-
- /** */
- public VisorClusterChangeTagTaskArg() {
- // No-op.
- }
-
- /** */
- public VisorClusterChangeTagTaskArg(String newTag) {
- this.newTag = newTag;
- }
+ @Positional
+ @Argument(javaStyleExample = true)
+ private String newTagValue;
/** {@inheritDoc} */
@Override protected void writeExternalData(ObjectOutput out) throws
IOException {
- out.writeObject(newTag);
+ U.writeString(out, newTagValue);
}
/** {@inheritDoc} */
@Override protected void readExternalData(byte protoVer, ObjectInput in)
throws IOException, ClassNotFoundException {
- newTag = (String)in.readObject();
+ newTagValue = U.readString(in);
+ }
+
+ /** */
+ public String newTagValue() {
+ return newTagValue;
}
/** */
- public String newTag() {
- return newTag;
+ public void newTagValue(String newTagValue) {
+ if (newTagValue.isEmpty())
Review Comment:
F.isEmpty()? Should we check it for null here?
##########
modules/core/src/main/java/org/apache/ignite/internal/management/api/CliConfirmParameter.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.management.api;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Marks commands that must output example of optional {@code --yes} parameter.
+ * Only for compatibility with existing {@code ./control.sh} output.
+ */
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.TYPE)
+public @interface CliConfirmParameter {
Review Comment:
I'd suggest to rename it, because it annotates class, and "parameter" looks
misleading. WithCliConfirmParameter? RequireConfirm?
##########
modules/core/src/main/java/org/apache/ignite/internal/management/ChangeTagCommandArg.java:
##########
@@ -1,12 +1,12 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
+ * contributor license agreements. See the NOTICE file distributed with
Review Comment:
Smth wrong here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
