ibessonov commented on code in PR #2016:
URL: https://github.com/apache/ignite-3/pull/2016#discussion_r1184612972
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/asm/InnerNodeAsmGenerator.java:
##########
@@ -514,6 +533,11 @@ private FieldDefinition addInnerNodeField(Field
schemaField) {
throw new IllegalArgumentException("Unsupported field: " +
schemaField);
}
+ dieldToDieldDefinitionMap.put(
+ schemaField,
+ innerNodeClassDef.declareField(EnumSet.of(PUBLIC, STATIC,
FINAL), fieldName + "FieldDefinition", Field.class)
Review Comment:
`fieldName + "FieldDefinition"` - poor naming. What do you mean by field
definition here? It looks more like "schema field". I would also make it upper
case, because it's a `static final` field.
Doesn't it break "polymorphic extensions"? They may have repeating
properties names, don't we have such tests? Please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
