SammyVimes commented on code in PR #2019:
URL: https://github.com/apache/ignite-3/pull/2019#discussion_r1185443363
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -231,12 +242,21 @@ private static List<ColumnFamilyDescriptor>
cfDescriptors() {
ColumnFamilyOptions dataFamilyOptions = new
ColumnFamilyOptions(dataOptions);
Options indexOptions = new Options().setCreateIfMissing(true);
-
ColumnFamilyOptions indexFamilyOptions = new
ColumnFamilyOptions(indexOptions);
+ Options tsToRevOptions = new Options().setCreateIfMissing(true)
+ .useFixedLengthPrefixExtractor(Integer.BYTES + Long.BYTES);
+ ColumnFamilyOptions tsToRevFamilyOptions = new
ColumnFamilyOptions(tsToRevOptions);
+
+ Options revToTsOptions = new Options().setCreateIfMissing(true)
+ .useFixedLengthPrefixExtractor(Long.BYTES);
Review Comment:
We don't actually need it at all, I removed it
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -231,12 +242,21 @@ private static List<ColumnFamilyDescriptor>
cfDescriptors() {
ColumnFamilyOptions dataFamilyOptions = new
ColumnFamilyOptions(dataOptions);
Options indexOptions = new Options().setCreateIfMissing(true);
-
ColumnFamilyOptions indexFamilyOptions = new
ColumnFamilyOptions(indexOptions);
+ Options tsToRevOptions = new Options().setCreateIfMissing(true)
+ .useFixedLengthPrefixExtractor(Integer.BYTES + Long.BYTES);
Review Comment:
Already removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
