sanpwc commented on code in PR #2030:
URL: https://github.com/apache/ignite-3/pull/2030#discussion_r1187279363
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuilder.java:
##########
@@ -100,10 +111,14 @@ void stop() {
*/
void startIndexBuild(TableIndexView tableIndexView, TableImpl table) {
for (int partitionId = 0; partitionId <
table.internalTable().partitions(); partitionId++) {
+ // Let's check if there is a node in the assignments for the
partition.
+ if (!replicaManager.startedGroups().contains(new
TablePartitionId(table.tableId(), partitionId))) {
Review Comment:
That's definitely not what I've meant. What about having build index logic
inside replica itself? The basic question here is whether we have any index
related logic if there's no replica locally?
If not, we should neither check assignments nor replicas but rather perform
index related logic inside replica. Of course it's still possible to used
IndexBuilder as an abstraction that will cover corresponding index related
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
