alievmirza commented on code in PR #2041:
URL: https://github.com/apache/ignite-3/pull/2041#discussion_r1190152340
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -283,6 +288,15 @@ public DistributionZoneManager(
);
topVerTracker = new PendingComparableValuesTracker<>(0L);
+
+ rebalanceEngine = new DistributionZoneRebalanceEngine(
+ stopGuard,
+ busyLock,
+ zonesConfiguration,
+ tablesConfiguration,
+ metaStorageManager,
+ this
Review Comment:
Please, add comment then, that it is safe here to escape partially
initialised object in such case and we do not violate some thread-safety rules
like
https://wiki.sei.cmu.edu/confluence/display/java/TSM01-J.+Do+not+let+the+this+reference+escape+during+object+construction,
https://wiki.sei.cmu.edu/confluence/display/java/TSM03-J.+Do+not+publish+partially+initialized+objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
