sashapolo commented on code in PR #2055: URL: https://github.com/apache/ignite-3/pull/2055#discussion_r1192247489
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/SchemaCompatValidator.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.replicator; + +import static java.util.concurrent.CompletableFuture.completedFuture; +import static java.util.stream.Collectors.toList; + +import java.util.List; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.replicator.TablePartitionId; +import org.apache.ignite.internal.table.distributed.schema.FullTableSchema; +import org.apache.ignite.internal.table.distributed.schema.Schemas; +import org.apache.ignite.internal.table.distributed.schema.TableDefinitionDiff; +import org.apache.ignite.internal.tx.TransactionIds; +import org.jetbrains.annotations.Nullable; + +/** + * Validates schema compatibility. + */ +class SchemaCompatValidator { + private final Schemas schemas; + + SchemaCompatValidator(Schemas schemas) { + this.schemas = schemas; + } + + /** + * Performs forward compatibility validation (if needed). That is, for each table enlisted in the transaction, + * checks to see whether the initial schema (identified by the begin timestamp) is forward-compatible with the + * commit schema (identified by the commit timestamp). + * + * <p>If doing an abort (and not commit), the validation always succeeds. + * + * @param txId ID of the transaction that gets validated. + * @param enlistedGroupIds IDs of the partitions that are enlisted with the transaction. + * @param commit Whether it's a commit attempt (otherwise it's an abort). + * @param commitTimestamp Commit timestamp (or {@code null} if it's an abort). + * @return Future completed with validation result. + */ + CompletableFuture<ForwardValidationResult> validateForwards( + UUID txId, + List<TablePartitionId> enlistedGroupIds, + boolean commit, + @Nullable HybridTimestamp commitTimestamp + ) { + if (!commit) { + return completedFuture(ForwardValidationResult.success()); + } + + HybridTimestamp beginTimestamp = TransactionIds.beginTimestamp(txId); + + List<UUID> tableIds = enlistedGroupIds.stream() Review Comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
