sashapolo commented on code in PR #2058:
URL: https://github.com/apache/ignite-3/pull/2058#discussion_r1194862473
##########
modules/configuration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationRegistryTest.java:
##########
@@ -137,10 +139,18 @@ void missingPolymorphicExtension() {
@Test
void testComplicatedPolymorphicConfig() throws Exception {
+
+ Map<String, Serializable> bootstrapConfig = Map.of(
Review Comment:
What is this for?
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -274,6 +274,9 @@ public void start() throws ConfigurationChangeException {
//Workaround for distributed configuration.
addDefaults(superRoot);
+ // Validate the restored configuration.
+ validateConfiguration(new SuperRoot(null), superRoot);
Review Comment:
`null` is not expected here, maybe `rootCreator()` is a better alternative
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -242,7 +242,7 @@ private Function<String, RootInnerNode> rootCreator() {
* Start component.
*/
// ConfigurationChangeException, really?
Review Comment:
You should remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
