nizhikov commented on code in PR #10710:
URL: https://github.com/apache/ignite/pull/10710#discussion_r1195317468
##########
modules/core/src/main/java/org/apache/ignite/internal/management/api/ComputeCommand.java:
##########
@@ -34,11 +34,11 @@
public Class<? extends ComputeTask<VisorTaskArgument<A>, R>> taskClass();
/**
- * @param nodes Live nodes. Key is node ID, Boolean is client flag, Object
is consistent id.
+ * @param nodes Live nodes. Key is node ID, Boolean is client flag, Object
is consistent id, Long is node order.
* @param arg Argument.
* @return nodes to execute command on, {@code null} means default node
must be used.
*/
- public default @Nullable Collection<UUID> nodes(Map<UUID, T2<Boolean,
Object>> nodes, A arg) {
+ public default @Nullable Collection<UUID> nodes(Map<UUID, T3<Boolean,
Object, Long>> nodes, A arg) {
Review Comment:
I don't want to do it in the moment.
We have several "Ignite node" classes in codebase, already. Like
`ClusterNode`, `BaselineNode`, `GridClientNode`, `ClientNode`, etc.
So, one more named node representation is too much here in my opinion.
Let's come back to this when all commands will be transfered to new
framework?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
