sanpwc commented on code in PR #2078:
URL: https://github.com/apache/ignite-3/pull/2078#discussion_r1196773652
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/Lease.java:
##########
@@ -23,17 +23,19 @@
import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
+import java.util.Objects;
import org.apache.ignite.internal.hlc.HybridTimestamp;
+import org.apache.ignite.internal.placementdriver.LeaseMeta;
/**
* A lease representation in memory.
* The real lease is stored in Meta storage.
*/
-public class Lease {
+public class Lease implements LeaseMeta {
/** The object is used when nothing holds the lease. Empty lease is always
expired. */
public static Lease EMPTY_LEASE = new Lease(null, MIN_VALUE, MIN_VALUE);
- /** A node that holds a lease until {@code stopLeas}. */
+ /** A node that holds a lease until {@code stopLeas}LeaseMeta. */
Review Comment:
Well, it wasn't part of my changes.
@vldpyatkov Could you please clarify what does it mean? Do you have any
objections for {@code stopLeas} removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
