[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2030: IGNITE-19177 Add assignments checks when building indexes

Thu, 18 May 2023 03:32:30 -0700 


tkalkirill commented on code in PR #2030:
URL: https://github.com/apache/ignite-3/pull/2030#discussion_r1197660758


##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -382,8 +382,17 @@ public boolean stopReplica(ReplicationGroupId 
replicaGrpId) throws NodeStoppingE
      * @param replicaGrpId Replication group id.
      * @return True if the replica is found and closed, false otherwise.
      */
+    // TODO: IGNITE-19494 We need to correctly stop the replica

Review Comment:
   I tried to paraphrase, but I don’t know what else to add, do you advise 
something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to