sanpwc commented on code in PR #2030:
URL: https://github.com/apache/ignite-3/pull/2030#discussion_r1199577985
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -382,8 +382,17 @@ public boolean stopReplica(ReplicationGroupId
replicaGrpId) throws NodeStoppingE
* @param replicaGrpId Replication group id.
* @return True if the replica is found and closed, false otherwise.
*/
+ // TODO: IGNITE-19494 We need to correctly stop the replica
Review Comment:
Instead of waiting we should complete the future exceptionally in order to
interrupt replica await process. Semantically, only if it's not completed
already, but who cares completeExceptionally will do the trick. We may
introduce ReplicaStoppingException or similar and verify that such kind of
exception is properly handled in `ReplicaService#sendToReplica`.
@vldpyatkov @sergeyuttsel Guys you've touched replica await code recently,
do you have any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
