korlov42 commented on code in PR #2101:
URL: https://github.com/apache/ignite-3/pull/2101#discussion_r1208966656


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteTableImpl.java:
##########
@@ -111,6 +114,9 @@ public class IgniteTableImpl extends AbstractTable 
implements IgniteTable, Updat
 
     private final PartitionExtractor partitionExtractor;
 
+    /** Triggers statistic update. */
+    private static AtomicBoolean updateStat = new AtomicBoolean();

Review Comment:
   yes, I see this. But still... You have _static_ field that initialised to 
`false` (default value for AtomicBoolean). You change this field to `true` once 
the table (not particular table, but random table since the field is static) 
has processed the very first insert from SQL (but not from KV). 
   
   After commit `e9b8fbf` this has even less sense, because you initialised 
this field to `true`, thus this field literally does nothing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to