sergeyuttsel commented on code in PR #2070:
URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1209958053
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -1038,7 +1038,9 @@ public void testOneNodeRestartWithGap() throws
InterruptedException {
/**
* Checks that the table created in cluster of 2 nodes, is recovered on a
node after restart of this node.
*/
- @Test
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-19506 here we
receive the empty nodes from baseline manager,
+ // but should get the nodes from metastore instead
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-19506";)
Review Comment:
The reason is on table creation `createTableAsyncInternal` invokes
`distributionZoneManager.topologyVersionedDataNodes(zoneId,
cmgTopology.version())` and recieves datanodes:[iinrt_troon_0] instead of
[iinrt_troon_0, iinrt_troon_1]. I fixed the same issue in
testOneNodeRestartWithGap by using `startNode(1);` instead of
`startPartialNode(1, null);`
At the last refinement, we decided that we will use this solution, close the
IGNITE-19408 ticket and I will remove this TODO in my next pr.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1277,6 +1296,7 @@ private void dropTableLocally(long causalityToken, String
name, int tblId, List<
private Set<Assignment> calculateAssignments(TableConfiguration tableCfg,
int partNum) {
return AffinityUtils.calculateAssignmentForPartition(
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-19506 we
must use distribution zone keys here
Review Comment:
Why did you add this TODO? Actually we will not use data nodes from zone
manager here when IGNITE-19506 will be implemented. We want to use data nodes
from zone manager here when https://issues.apache.org/jira/browse/IGNITE-19425
will be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
