PakhomovAlexander commented on code in PR #2102:
URL: https://github.com/apache/ignite-3/pull/2102#discussion_r1210108258
##########
modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java:
##########
@@ -58,7 +58,7 @@ public class DeploymentUnitStoreImplTest {
private final VaultManager vaultManager = new VaultManager(new
InMemoryVaultService());
- private final List<UnitNodeStatus> history = new ArrayList<>();
+ private final Set<UnitNodeStatus> history = ConcurrentHashMap.newKeySet();
Review Comment:
Set is not the best solution here. It might hide the duplicates. I think
duplicates are an important part to check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
