xtern commented on code in PR #2085:
URL: https://github.com/apache/ignite-3/pull/2085#discussion_r1214043694
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEvent.java:
##########
@@ -31,4 +31,10 @@ public enum CatalogEvent implements Event {
/** This event is fired, when a column was added to or dropped from a
table. */
TABLE_ALTER,
+
+ /** This event is fired, when a index was created in Catalog. */
Review Comment:
```suggestion
/** This event is fired, when an index was created in Catalog. */
```
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManager.java:
##########
@@ -59,4 +62,28 @@ public interface CatalogManager extends IgniteComponent,
CatalogService {
* @return Operation future.
*/
CompletableFuture<Void> dropColumn(AlterTableDropColumnParams params);
+
+ /**
+ * Creates new sorted index.
+ *
+ * @param params Parameters.
+ * @return Operation future.
+ */
+ CompletableFuture<Void> createIndex(CreateSortedIndexParams params);
+
+ /**
+ * Creates new index.
Review Comment:
Creates new `hash` index?
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEvent.java:
##########
@@ -31,4 +31,10 @@ public enum CatalogEvent implements Event {
/** This event is fired, when a column was added to or dropped from a
table. */
TABLE_ALTER,
+
+ /** This event is fired, when a index was created in Catalog. */
+ INDEX_CREATE,
+
+ /** This event is fired, when a index was dropped in Catalog. */
Review Comment:
```suggestion
/** This event is fired, when an index was dropped in Catalog. */
```
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlSynchronousApiTest.java:
##########
@@ -101,6 +102,7 @@ protected IgniteTransactions igniteTx() {
return CLUSTER_NODES.get(0).transactions();
}
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-19592";)
Review Comment:
This ticket has been resolved already :thinking:
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CreateIndexEventParameters.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.catalog.events;
+
+import org.apache.ignite.internal.catalog.descriptors.IndexDescriptor;
+
+/**
+ * Create index event parameters contains a index descriptor for a newly
created index.
Review Comment:
```suggestion
* Create index event parameters contains an index descriptor for a newly
created index.
```
:thinking: `...parameters contains` is also looks incorrect, but we seem to
already have it in neighboring classes)
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -119,6 +120,7 @@ protected IgniteTransactions igniteTx() {
return CLUSTER_NODES.get(0).transactions();
}
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-19592";)
Review Comment:
This ticket has been resolved already :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
