AMashenkov commented on code in PR #2145:
URL: https://github.com/apache/ignite-3/pull/2145#discussion_r1219184429
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java:
##########
@@ -148,18 +150,19 @@ public SqlSchemaManagerImpl(
/** {@inheritDoc} */
@Override
- public SchemaPlus schema(@Nullable String schema) {
+ public SchemaPlus schema(@Nullable String schema, HybridTimestamp ts) {
+ Objects.requireNonNull(ts, "timestamp");
SchemaPlus schemaPlus = calciteSchemaVv.latest();
// stub for waiting pk indexes, more clear place is IgniteSchema
CompletableFuture.allOf(pkIdxReady.values().toArray(CompletableFuture[]::new)).join();
- return schema != null ? schemaPlus.getSubSchema(schema) :
schemaPlus.getSubSchema(DEFAULT_SCHEMA_NAME);
+ return getSchemaOrDefault(schema, schemaPlus);
Review Comment:
```suggestion
return schemaPlus.getSubSchema(Objects.requireNonNullOrElse(schema,
DEFAULT_SCHEMA_NAME));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
