korlov42 commented on code in PR #2047:
URL: https://github.com/apache/ignite-3/pull/2047#discussion_r1220912877


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeSystem.java:
##########
@@ -148,4 +149,36 @@ public RelDataType deriveSumType(RelDataTypeFactory 
typeFactory, RelDataType arg
 
         return typeFactory.createTypeWithNullability(sumType, 
argumentType.isNullable());
     }
+
+    /**
+     * Checks that {@code toType} and {@code fromType} have compatible type 
families taking into account custom data types.

Review Comment:
   Could you please clarify what compatibility means?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to