AMashenkov commented on code in PR #2162:
URL: https://github.com/apache/ignite-3/pull/2162#discussion_r1221607145
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -425,6 +421,18 @@ private CompletableFuture<AsyncSqlCursor<List<Object>>>
querySingle0(
.thenCompose(sqlNode -> {
boolean rwOp = dataModificationOp(sqlNode);
+ boolean implicitTxRequired = outerTx == null;
+
+ tx.set(implicitTxRequired ? txManager.begin(!rwOp) :
outerTx);
+
+ SchemaPlus schema = sqlSchemaManager.schema(schemaName);
Review Comment:
SqlSchemaManager methods without version or timestamp must not be used, and
it is better to drop them at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
