sashapolo commented on code in PR #2150:
URL: https://github.com/apache/ignite-3/pull/2150#discussion_r1222516479
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuple.java:
##########
@@ -27,59 +27,33 @@
* elements as objects.
*/
public class BinaryTuple extends BinaryTupleReader implements InternalTuple {
- /** Tuple schema. */
- private final BinaryTupleSchema schema;
-
/**
* Constructor.
*
- * @param schema Tuple schema.
+ * @param elementCount Number of tuple elements.
* @param bytes Binary tuple.
*/
- public BinaryTuple(BinaryTupleSchema schema, byte[] bytes) {
- super(schema.elementCount(), bytes);
- this.schema = schema;
+ public BinaryTuple(int elementCount, byte[] bytes) {
+ super(elementCount, bytes);
}
/**
* Constructor.
*
- * @param schema Tuple schema.
+ * @param elementCount Number of tuple elements.
* @param buffer Buffer with a binary tuple.
*/
- public BinaryTuple(BinaryTupleSchema schema, ByteBuffer buffer) {
- super(schema.elementCount(), buffer);
- this.schema = schema;
+ public BinaryTuple(int elementCount, ByteBuffer buffer) {
+ super(elementCount, buffer);
}
- /** {@inheritDoc} */
@Override
- public int count() {
- return elementCount();
+ public BigDecimal decimalValue(int col) {
Review Comment:
Actually, I found a way around it (don't know why I didn't see it
yesterday), let's see if the tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
