vldpyatkov commented on code in PR #2142:
URL: https://github.com/apache/ignite-3/pull/2142#discussion_r1222907486
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/disruptor/StripedDisruptor.java:
##########
@@ -214,7 +214,7 @@ void unsubscribe(NodeId nodeId) {
assert handler != null : format("Group of the event is unsupported
[nodeId={}, event={}]", event.nodeId(), event);
//TODO: IGNITE-15568 endOfBatch should be set to true to prevent
caching tasks until IGNITE-15568 has fixed.
- handler.onEvent(event, sequence, true);
+ handler.onEvent(event, sequence, subscribers.size() > 1 ? true :
endOfBatch);
Review Comment:
We don't have a test that will be able to demonstrate that. I assume, that
update is not doing worse at least.
Theoretically, RAFT log may fsync less often in the circumstance when
several RAFT commands are executing simultaniously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
