lowka commented on code in PR #2159:
URL: https://github.com/apache/ignite-3/pull/2159#discussion_r1223442333
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/fun/IgniteSqlOperatorTable.java:
##########
@@ -103,10 +102,16 @@ public class IgniteSqlOperatorTable extends
ReflectiveSqlOperatorTable {
* Generic {@code SUBSTR(string, position [, length]} function.
* This function works exactly the same as {@link SqlSubstringFunction
SUSBSTRING(string, position [, length])}.
*/
- public static final SqlFunction SUBSTR = new SqlFunction("SUBSTR",
SqlKind.OTHER_FUNCTION,
- ReturnTypes.ARG0_NULLABLE_VARYING, null,
- OperandTypes.STRING_INTEGER_OPTIONAL_INTEGER,
- SqlFunctionCategory.STRING);
+ public static final SqlFunction SUBSTRING = new SqlSubstringFunction();
Review Comment:
I think it would be better swap `SUBSTRING` and `SUBSTR`, since a comment
over `SUBSTRING` belongs to `SUBSTR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
