valepakh commented on code in PR #2151:
URL: https://github.com/apache/ignite-3/pull/2151#discussion_r1224502407
##########
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DownloadTracker.java:
##########
@@ -43,9 +43,9 @@ public class DeployTracker {
* @param trackableAction Deploy action.
* @return {@param trackableAction}.
*/
- public <T> CompletableFuture<T> track(String id, Version version,
CompletableFuture<T> trackableAction) {
+ public <T> CompletableFuture<T> track(String id, Version version,
Supplier<CompletableFuture<T>> trackableAction) {
ByteArray key =
ClusterStatusKey.builder().id(id).version(version).build().toByteArray();
Review Comment:
Do we really need to serialize the key to ByteArray here? It's only used as
a map key and since ClusterStatusKey has a hashCode/equals implemented, it's
perfectly fine to use it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
