sanpwc commented on code in PR #2183:
URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228359724
##########
modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java:
##########
@@ -313,17 +313,17 @@ public static void
deployWatchesAndUpdateMetaStorageRevision(MetaStorageManager
throws NodeStoppingException, InterruptedException {
// Watches are deployed before distributionZoneManager start in order
to update Meta Storage revision before
// distributionZoneManager's recovery.
- metaStorageManager.deployWatches();
+ var deployWatchesFut = metaStorageManager.deployWatches();
Review Comment:
> I think it is possible for test purposes.
I've never heard about such possibilities for test classes. Is it allowed by
our coding conventions?
##########
modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java:
##########
@@ -313,17 +313,17 @@ public static void
deployWatchesAndUpdateMetaStorageRevision(MetaStorageManager
throws NodeStoppingException, InterruptedException {
// Watches are deployed before distributionZoneManager start in order
to update Meta Storage revision before
// distributionZoneManager's recovery.
- metaStorageManager.deployWatches();
+ var deployWatchesFut = metaStorageManager.deployWatches();
Review Comment:
> I think it is possible for test purposes.
I've never heard about such possibilities for test classes. Is it allowed by
our coding conventions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
