sanpwc commented on code in PR #2183:
URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1230688779
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -494,24 +492,15 @@ private PartialNode startPartialNode(
fut -> new TestConfigurationCatchUpListener(cfgStorage, fut,
revisionCallback0)
);
- CompletableFuture<?> notificationFuture = CompletableFuture.allOf(
+ CompletableFuture<?> startFuture = CompletableFuture.allOf(
nodeCfgMgr.configurationRegistry().notifyCurrentConfigurationListeners(),
-
clusterCfgMgr.configurationRegistry().notifyCurrentConfigurationListeners()
+
clusterCfgMgr.configurationRegistry().notifyCurrentConfigurationListeners(),
+ // Deploy all registered watches because all components are
ready and have registered their listeners.
+ metaStorageMgr.deployWatches(),
+ configurationCatchUpFuture
);
- CompletableFuture<?> startFuture = notificationFuture
- .thenCompose(v -> {
- // Deploy all registered watches because all components
are ready and have registered their listeners.
- try {
- metaStorageMgr.deployWatches();
- } catch (NodeStoppingException e) {
- throw new CompletionException(e);
- }
-
- return configurationCatchUpFuture;
- });
-
- assertThat(startFuture, willCompleteSuccessfully());
+ assertThat("Partial node was not started", startFuture,
willCompleteSuccessfully());
Review Comment:
Really? Seems that originally there was
notificationFuture(notifyCurrentConfigurationListeners,
notifyCurrentConfigurationListeners).thenCompose(deployWatches) and now it's
startFuture(notifyCurrentConfigurationListeners,
notifyCurrentConfigurationListeners, deployWatches) in other words originally
deployWatches was called after notificationFutures and now it's called
concurrently. Am I mistaken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
