tkalkirill commented on code in PR #2197:
URL: https://github.com/apache/ignite-3/pull/2197#discussion_r1232112316
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/GcUpdateHandler.java:
##########
@@ -69,41 +68,74 @@ public PendingComparableValuesTracker<HybridTimestamp,
Void> getSafeTimeTracker(
*
* @param lowWatermark Low watermark for the vacuum.
* @param count Count of entries to GC.
+ * @param strict {@code true} if needed to remove the strictly passed
{@code count} oldest stale entries, {@code false} if a premature
+ * exit is allowed when it is not possible to acquire a lock for the
{@link RowId}.
* @return {@code False} if there is no garbage left in the storage.
*/
- public boolean vacuumBatch(HybridTimestamp lowWatermark, int count) {
+ public boolean vacuumBatch(HybridTimestamp lowWatermark, int count,
boolean strict) {
+ if (count <= 0) {
+ return true;
+ }
+
+ IntHolder countHolder = new IntHolder(count);
Review Comment:
I'd rather leave it as is because it's closer (as api usage) to using
**AtomicInteger**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
