sanpwc commented on code in PR #2227:
URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236521868
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -60,6 +61,13 @@ public interface MetaStorageManager extends IgniteComponent {
*/
CompletableFuture<Entry> get(ByteArray key, long revUpperBound);
+ /**
+ * Retrieves entries for the given key and bound revisions.
+ * TODO: IGNITE-19735 move this method to another interface for
interaction with local KeyValueStorage.
+ */
+ @Deprecated
+ List<Entry> getEntriesLocally(byte[] key, long revLowerBound, long
revUpperBound);
Review Comment:
Let's be consistent with other methods naming. There are bunch of method in
`MetaStorageManager`, `RocksDbKeyValueStorage` and other related places that
return entries, however neither of them have entries in it's name, you on the
contrary introduces getEntriesLocally. Please rename it and all related
`getEntries`, `doGetEntries`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
