tkalkirill commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237562111
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterColumnEventParameters.java:
##########
@@ -23,32 +23,36 @@
* Create table event parameters contains a column descriptor for the modified
column.
*/
public class AlterColumnEventParameters extends CatalogEventParameters {
-
private final int tableId;
- private final CatalogTableColumnDescriptor columnDescriptor;
+ private final CatalogTableColumnDescriptor descriptor;
/**
* Constructor.
*
* @param causalityToken Causality token.
- * @param tableId Returns an id the table to be modified.
- * @param columnDescriptor Descriptor for the column to be replaced.
+ * @param catalogVersion Catalog version.
+ * @param tableId Returns ID the table to be modified.
+ * @param descriptor Descriptor for the column to be replaced.
*/
- public AlterColumnEventParameters(long causalityToken, int tableId,
CatalogTableColumnDescriptor columnDescriptor) {
- super(causalityToken);
+ public AlterColumnEventParameters(long causalityToken, int catalogVersion,
int tableId, CatalogTableColumnDescriptor descriptor) {
+ super(causalityToken, catalogVersion);
this.tableId = tableId;
- this.columnDescriptor = columnDescriptor;
+ this.descriptor = descriptor;
}
- /** Returns an id of a modified table. */
+ /**
+ * Returns ID of a modified table.
+ */
Review Comment:
It is grammatically correct to use ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
