ibessonov commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238084242
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEventParameters.java:
##########
@@ -23,12 +23,24 @@
* Base class for Catalog event parameters.
*/
public abstract class CatalogEventParameters extends EventParameters {
+ private final int catalogVersion;
+
/**
* Constructor.
*
* @param causalityToken Causality token.
+ * @param catalogVersion Catalog version.
*/
- public CatalogEventParameters(long causalityToken) {
+ public CatalogEventParameters(long causalityToken, int catalogVersion) {
Review Comment:
I was involved in it. Right now we only have meta-storage revision as a
causality token. If we use two different entities, calling it the same name, it
will lead to confusion. It's easier and safer to migrate meta-storage revision
into a catalog version later with a single commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
