sashapolo commented on code in PR #2228:
URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238464931
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java:
##########
@@ -209,13 +214,14 @@ public CompletableFuture<Void> onUpdate(WatchEvent event)
{
VersionedUpdate update = fromBytes(payload);
- onUpdateHandler.handle(update);
+ HybridTimestamp entryTimestamp =
metastoreRevisionToTs.apply(eventEntry.newEntry().revision());
Review Comment:
Actually, all events in a single notification will have the same revision,
so it's kind of pointless to query it for all entries.
Also, why do we have to do a lookup at all? We have a timestamp as a part of
every Raft command, so why can't Meta Storage include it in its notifications?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
