tkalkirill commented on code in PR #2247:
URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241839211
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java:
##########
@@ -295,7 +306,7 @@ public CompletableFuture<Void> dropTable(DropTableParams
params) {
Arrays.stream(schema.indexes())
.filter(index -> index.tableId() == table.id())
- .forEach(index -> updateEntries.add(new
DropIndexEntry(index.id())));
+ .forEach(index -> updateEntries.add(new
DropIndexEntry(index.id(), index.tableId())));
Review Comment:
Only the indexId being deleted gets into the event, and to get it you need
to refer to the previous version of the catalog, which seems a little more
redundant than just passing the tableId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
